Draft (review) notes can generate wrong suggestions
- The user leaves a suggestion as a review note (the suggestion wasn't created in the DB yet)
- Before finishing up and sending the review as comment, the file that received the "pre-suggestion" changes
- Currently, when publishing the note (review note -> diff note) we use the
note.original_positionto fetch the
diffcontent to generate the suggestion. That means that when a
DiffNote, the MR might have received updates, so the
original_positionmight be pointing to an old revision, therefore in the transition time we might fetch old content to generate the suggestion, which might be confusing to the user.