Multiple approval rules tricky min enforcement
Description
The current release of #1979 (closed) does not enforce minimum approvals required under some circumstances. Let's iterate over this, to see what the best solution is (which might even be a change in requirements).
Situation:
- Premium license (allow multiple approval rules)
- Project settings has no rules, but has a fallback of 3 approvals required.
- Project settings has "Override approvers" checked
- By default a MR will have no rules, but the user can add some because "override" is checked
- User adds a rule with 0 approvals required. Since the rule has no "project rule" backing it, this is allowed.
☹
Edited by James Ramsay (ex-GitLab)