Option to turn on Self Approval of Merge Requests for a Master
Description
With reference to this https://gitlab.com/gitlab-org/gitlab-ee/issues/388, a customer proposing:
Before it was required that two persons give the approval and it didn’t matter if one of the approvers was the creator of a merge request. Since the approvers where two masters it was ideal for us. A normal developer needed two approvals where as a master could give his own approval.
Proposal
It would be great if there would be an exception for masters, so that we could always add a master to the list of approvers. Also I like to suggest that GitLab should support hooks in such places, I can imagine that it’s not easy to satisfy all the needs of different customers and that might really help here. If the hook is missing the default rule (at the point of project creation) is applied, otherwise the hook is used, so you can keep gitlab easy to setup for all others. The hook might get the following input parameters: project, source branch, target branch, existingApprovers, newApprover and just return a boolean.
Links / references
https://gitlab.zendesk.com/agent/tickets/36476 https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/560