Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,761
    • Issues 44,761
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,329
    • Merge requests 1,329
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #9255
Closed
Open
Issue created Jan 17, 2019 by Liam McAndrew@lmcandrew🚰Developer

Implement access controls when SSO enforcement enabled

Description

In Issue https://gitlab.com/gitlab-org/gitlab-ee/issues/5291 we will be adding a group setting to enable SSO enforcement. Once this is done we will have to add various controls to restrict access to any group with SSO enforcement enabled.

Proposal

We need to add the following access controls and validations:

  1. Prevent non-SSO users being added to the group
  2. Prevent access to basic group resources by intercepting find_routable!
  3. Prevent access to basic project resources via find_routable!

We also need to consider the following:

  • Ensure that controllers that don't user find_routable! or authenticate_user! still check SSO enforcement, but also check they still work rather than always blocking access
  • Access checks when looking up multiple groups/projects at once such as from the projects dashboard

When access is prevented the user should be redirected to the SSO page.

Edited Jan 17, 2019 by Liam McAndrew
Assignee
Assign to
Time tracking