Skip to content

Promote issue to epic "may expose confidential information" warning needs explanation

Problem

I knew we could promote issues to epics, and went to use it for the first time. I found https://docs.gitlab.com/ee/user/group/epics/#promoting-an-issue-to-an-epic and typed /promote into the comment field and saw:

image

I thought: "Oh no, what am I about to expose?". And googled site:gitlab.com "may expose confidential information" and got nothing useful:

image

At this point, many users will stop and never use the action.

As a GitLab dev, I found the string in the code, and found the MR and issue, but I'm actually still a little worried something unexpected could happen. Should the warning be displayed at all on a public issue of a public project?

If we want users to use the action, they need to know with more certainty what will happen if they use it.

Proposal

Add-on proposals

  • Hide the warning if irrelevant
  • Ideally link to the doc from the warning, but that's probably not possible on the select?

Design proposal

  1. The most pressing requirement here is exposing this warning only when it is relevant to the user, and not in every issue.
  2. Update the warning to better correlate this warning to the confidential banner, using the style of our alert component.

Here are specs for the cell: https://gitlab-org.gitlab.io/gitlab-design/hosted/alexis/ee%239125-promote-spec-previews/

Simplified specs below:

  • Banner height: 24px
  • Banner background color: #FFF1DE
  • Banner font color: #A35200
  • Confidential icon, 4px spacing between icon and text
  1. Update the banner copy that appears after a user has promoted their issue to Promoted issue to epic. Information in this issue is no longer confidential as epics are public to group members.
Edited by Alexis Ginsberg