Empty state shown when the group security dashboard request fails

Summary

I was testing the error states on staging and I noticed that an error in fetching the vulnerabilities displayed the empty state.

It's a quick fix on the FE, but I wanted to check with UX to see if it should be there or not. I'm assuming not, but it's best to ask first.

Steps to reproduce

  1. Go to https://staging.gitlab.com/groups/secure-team-test/-/security/dashboard (or any project on staging with a group security dashboard).
  2. Open up the network tab in dev tools and block requests to staging.gitlab.com/groups/secure-team-test/-/security/vulnerabilities?page=1
  3. refresh the page

What is the current bug behavior?

You see both the error state and the empty state at the same time.

What is the expected correct behavior?

Probably just the error state, though I'm not sure.

Relevant logs and/or screenshots

image

Output of checks

This happens on staging.gitlab.com

Possible fixes

It's just an extra logic check in the FE code. I'm not 100% sure where bit it won't be hard to find.