gitlab:check rake task still reports Elasticsearch versions 5.1 - 5.5 as compatible on GitLab 11.5
Summary
According to GitLab 11.5 release notes, but gitlab:check rake task still expects to see versions 5.1 - 5.5.
Steps to reproduce
Run sudo gitlab-rake gitlab:check
on your instance of GitLab 11.5.x with the compatible Elasticsearch installed and check the output related to Elasticsearch. You will see something like this: Elasticsearch version 5.1 - 5.5? ... no (6.5.1)
What is the current bug behavior?
Compatible Elasticsearch versions are reported as bad
while incompatible deprecated versions are reported as good
.
What is the expected correct behavior?
gitlab:check
should report compatibility correctly.
Relevant logs and/or screenshots
n/a
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Debian 8.10 Proxy: no Current User: git Using RVM: no Ruby Version: 2.4.5p335 Gem Version: 2.7.6 Bundler Version:1.16.6 Rake Version: 12.3.1 Redis Version: 3.2.12 Git Version: 2.18.1 Sidekiq Version:5.2.1 Go Version: unknown
GitLab information Version: 11.5.0-ee Revision: cb71fca Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql DB Version: 9.6.8 URL: https://hostname.tld HTTP Clone URL: https://hostname.tld/some-group/some-project.git SSH Clone URL: git@hostname.tld:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers: google_oauth2, gitlab
GitLab Shell Version: 8.4.1 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
gitlab-rake gitlab:check SANITIZE=true
Checking GitLab Shell ...
GitLab Shell version >= 8.4.1 ? ... OK (8.4.1) hooks directories in repos are links: ... ... Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ... ... MailRoom running? ... skipped
Checking Reply by email ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... ... Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.4.5) Git version >= 2.9.5 ? ... yes (2.18.1) Git user has default SSH configuration? ... yes Active users: ... 7 Elasticsearch version 5.1 - 5.5? ... no (6.5.1) Checking GitLab ... Finished
Possible fixes
Update the message in https://gitlab.com/gitlab-org/gitlab-ee/blob/master/ee/lib/system_check/app/elasticsearch_check.rb#L4 and the check?
method in https://gitlab.com/gitlab-org/gitlab-ee/blob/master/ee/lib/system_check/app/elasticsearch_check.rb#L4