logging['udp_log_shipping_host'] breaks reconfigure in 11.5

Having set logging['udp_log_shipping_host'] = "qradar.example.net" in gitlab.rb breaks the upgrade to 11.5 with the follwong error message:

``Resource Declaration: --------------------- # In /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab/recipes/remote-syslog.rb

 34: template File.join(remote_syslog_dir, "remote_syslog.yml") do
 35:   mode "0644"
 36:   variables(node['gitlab']['remote-syslog'].to_hash)
 37:   notifies :restart, 'service[remote-syslog]' if omnibus_helper.should_notify?("remote-syslog")
 38: end
 39:

Compiled Resource:
------------------
# Declared in /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab/recipes/remote-syslog.rb:34:in `from_file'

template("/var/opt/gitlab/remote-syslog/remote_syslog.yml") do
  action [:create]
  default_guard_interpreter :default
  source "remote_syslog.yml.erb"
  variables {"enable"=>true, "ha"=>false, "dir"=>"/var/opt/gitlab/remote-syslog", "log_directory"=>"/var/log/gitlab/remote-syslog", "destination_host"=>"qradar.example.net", "destination_port"=>514, "services"=>["redis", "nginx", "unicorn", "gitlab-rails", "gitlab-shell", "postgresql", "sidekiq", "gitlab-workhorse", "gitlab-pages"], "svlogd_prefix"=>"gitlab remote-syslog: "}
  declared_type :template
  cookbook_name "gitlab"
  recipe_name "remote-syslog"
  mode "0644"
  owner nil
  group nil
  path "/var/opt/gitlab/remote-syslog/remote_syslog.yml"
  verifications []
end

Template Context:
-----------------
on line #3
  1: files:
  2: <% @services.each do |service| %>
  3:   - <%= File.join(node['gitlab'][service]['log_directory'], "*.log") %>
  4: <% end %>
  5: exclude_files:

System Info:
------------
chef_version=13.6.4
platform=ubuntu
platform_version=16.04
ruby=ruby 2.4.5p335 (2018-10-18 revision 65137) [x86_64-linux]
program_name=/opt/gitlab/embedded/bin/chef-client
executable=/opt/gitlab/embedded/bin/chef-client

Running handlers: There was an error running gitlab-ctl reconfigure:

no implicit conversion of nil into String

Assignee Loading
Time tracking Loading