Approvals API incomplete

Problem to solve

There are multiple settings for approvals that are missing from the API. It is problematic that they cannot be managed via the API

Settings API
image 
{
  "approvers":[],
  "approver_groups":[],
  "approvals_before_merge":1,
  "reset_approvals_on_push":true,
  "disable_overriding_approvers_per_merge_request":false
}

Further details

Use case from original request:

We've just migrated 100+ Chef cookbooks from Gerrit to GitLab.

I was able to enable required approval count > 1 for this but I was NOT able to enable "only merge on pipeline success".

Without an API I'm... effed.

Proposal

Provide missing options in Approvals API

Links / references

Edited by 🤖 GitLab Bot 🤖