Skip to content

Provide a view over the MR where the reviewer will view a compiled git history of commits honouring --fixup commits

Slightly related to https://gitlab.com/gitlab-org/gitlab-ee/issues/212

Problem to solve

For reviewers, having a clean history of commits makes a big difference.

For authors, keeping a clean history of commits is hard to maintain, especially after the initial feedback of reviews start pouring in and there's more people working on the same branch, which kind of prevents you from constantly squashing commits and git push -f (or --force-with-lease).

Further details

(Include use cases, benefits, and/or goals)

Proposal

Having a mode in the MR that would allow the review to be done on a git history that honours --fixup commits.

Example

Screen_Shot_2018-09-26_at_16.07.19

After this mode is enabled, clicking on a "squashed" commit would take the reviewer to the Changes tab and show the squashed changes.

(no mockup for this)

What does success look like, and how can we measure that?

Reviewers will have a better time reviewing (user satisfaction).

More commits starting with fixup! , as user education would be part of this.

Links / references

Edited by 🤖 GitLab Bot 🤖