`An error occurred while loading commit signatures` on Projects without Repository

Summary

An error occurred while loading commit signatures is shown on projects where Repository Permission is deactivated but a Repository once was created.

Steps to reproduce

  • Create Project
  • Init Repository with sample data
  • Disable Repository permission in Settings > General > Permission
  • Open the Project Overview
  • The message An error occurred while loading commit signatures appears
  • From the network log I can see that the following request fails with a 404: https://…/…/commits/master/signatures

What is the current bug behavior?

An error occurred while loading commit signatures is shown on project overviews.

What is the expected correct behavior?

An error occurred while loading commit signatures is not shown on project overviews.

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:		Ubuntu 16.04
Proxy:		no
Current User:	git
Using RVM:	no
Ruby Version:	2.4.4p296
Gem Version:	2.7.6
Bundler Version:1.16.2
Rake Version:	12.3.1
Redis Version:	3.2.11
Git Version:	2.18.0
Sidekiq Version:5.1.3
Go Version:	unknown


GitLab information
Version:	11.3.0-ee
Revision:	4e822ac
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	postgresql
DB Version:	9.6.6
URL:		https://hpm.agency
HTTP Clone URL:	https://hpm.agency/some-group/some-project.git
SSH Clone URL:	git@hpm.agency:some-group/some-project.git
Elasticsearch:	no
Geo:		no
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers: google_oauth2


GitLab Shell
Version:	8.3.3
Repository storage paths:
  • default: /gitlab-data/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
…]
24/2875 ... yes
61/2876 ... yes
2/2877 ... yes
41/2878 ... yes

Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.5 ? ... yes (2.4.4)
Git version >= 2.9.5 ? ... yes (2.18.0)
Git user has default SSH configuration? ... yes
Active users: ... 69
Elasticsearch version 5.1 - 5.5? ... skipped (elasticsearch is disabled)


Checking GitLab ... Finished
Edited by Mario