MR can be approved after someone else opens and I pushed on the same MR.

Hey Guys,

I am no sure if this is intended but in our on-prem Gitlab EE instance we can approve a MR when someone else opens it and after review if I think I have something to add, after pushing to the same branch (MR shows my commit and history) still I can approve the MR.

Is it something intended if so not sure if anyone else has come across this problem but we need to review the MR and approve the whole group can see the MR and can approve but when I have pushed something to the MR I think I should not be allowed to approve the MR.

Can someone comment on it please?

Thanks Manas

Problem to solve

After opening a MR if someone from the approvers push to the branch the approver should not be able to approve the MR

Further details

I am not sure if this is intended but in our on-prem Gitlab EE instance we can approve a MR when someone else opens it and after review if I think I have something to add, after pushing to the same branch (MR shows my commit and history) still I can approve the MR.

Proposal

Is it something intended if so not sure if anyone else has come across this problem but we need to review the MR and approve the whole group can see the MR and can approve but when I have pushed something to the MR I think I should not be allowed to approve the MR.

What does success look like, and how can we measure that?

Links / references