[Rails5] Couldn't find User with 'id'=1289

Note: add rails5 to a branch name to trigger rails5 specific CI jobs.

https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/82210157

  1) User deletes milestone deletes milestone
     Failure/Error: raise RecordNotFound.new(error, name, key, ids)

     ActiveRecord::RecordNotFound:
       Couldn't find User with 'id'=1289

I think the problem here is related to using set() with selenium and database_cleaner. If so, this is known issue.
The fix is simple: replace set() with let() / let!() in the failed spec and things should be good.

One more failed spec with the same error.

https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/82209299

rspec ./spec/features/milestones/user_creates_milestone_spec.rb:14 # User creates milestone creates milestone
Edited by blackst0ne