Current LDAP issue prioritization (meta)
Meta issue to list and prioritize all current LDAP bugs or feature requests.
cc/ @JobV @DouweM @jacobvosmaer-gitlab
The top issues related to LDAP (in my mind) are those below. I listed them in order of my perceived priority.
-
Allow
LDAPGroupSync
to accept a group name/id to sync individually ~"feature proposal" Blocks https://gitlab.com/gitlab-org/gitlab-ee/issues/400 (next item) - Change LDAP group sync 'Clear cache' to 'Sync now' ~"feature proposal"
- Seek alternative to AD recursive filter search ~"bug"
- Allow option to change permission levels of users when LDAP group sync is enabled ~"feature proposal" customer
-
Avoid spurious
ldap_blocked
issues ~"bug" - Improve error message when LDAP user is outside filter ~bug customer
- LDAP multi-domain group sync support ~"feature proposal" customer
- Add compound group sync filter ~"feature proposal" customer
-
Implement
group_filter
for group sync ~"feature proposal" customer
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Contributor
Thanks @dblessing
- Author Maintainer
@JobV I added the top almost 10 items related to LDAP, in order of my perceived priority. Although the first few are feature requests they are closely related and are really important. Implementing those items will remove the 'exclusive lease' which is making it really hard for the support team to debug with customers.
I'll start work on this list. Please feel free to add to the list or propose re-ordering.
- Contributor
@dblessing re ExclusiveLease; something I have done/seen elsewhere in the app is to have a lease-free sidekiq job that can be scheduled by a user via the UI, and a lease-obtaining 'cron job' that uses the lease-free job under the hood. See e.g. the repository check feature.
- Author Maintainer
@jacobvosmaer-gitlab That may work, but would also add some complexity. The leasing has to be done for each group, in the group loop. So we would have to pass in a boolean whether to get a lease or not. I think we can accomplish the same by using states and state will be required anyway to show the current status in the members page. I'll ping you on the WIP MR so you can see the implementation and see if it will work.
- Contributor
@dblessing thanks, I agree states make more sense if you want to report to the user.
- Job van der Voort Milestone changed to %16
Milestone changed to %16
- Job van der Voort Added ~157393 label
Added ~157393 label
- Drew Blessing Marked the task Allow
LDAPGroupSync
to accept a group name/id to sync individually ~"feature proposal" Blocks https://gitlab.com/gitlab-org/gitlab-ee/issues/400 (next item) as completedMarked the task Allow
LDAPGroupSync
to accept a group name/id to sync individually ~"feature proposal" Blocks https://gitlab.com/gitlab-org/gitlab-ee/issues/400 (next item) as completed - Drew Blessing Marked the task Change LDAP group sync 'Clear cache' to 'Sync now' ~"feature proposal" as completed
Marked the task Change LDAP group sync 'Clear cache' to 'Sync now' ~"feature proposal" as completed
- Drew Blessing Marked the task Allow option to change permission levels of users when LDAP group sync is enabled ~"feature proposal" customer as completed
Marked the task Allow option to change permission levels of users when LDAP group sync is enabled ~"feature proposal" customer as completed
- Author Maintainer
Probable LDAP features/fixes for 8.12 are below. All are in progress and in varying states of review. I reasonably expect they'll all be done in the next few days.
It will be a GREAT release for LDAP users- CE: Restrict LDAP return attributes (performance) https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6187
- EE: Restrict LDAP return attributes (performance) https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/712 (Final review)
- EE: Active Directory range member/nested group retrieval (bug fix/performance) https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/719 (WIP)
- EE: Allow membership override when using LDAP group sync https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/717 (Final review)
- EE: Add Sync now to group members page https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/704 (Final review)
Edited by Drew Blessing Looks like you've got some nice LDAP features in the works! Any chance you can slip #139 (closed) into an upcoming release? I realize it might be late in the game for 8.12, but perhaps 8.13?
- Drew Blessing Marked the task Seek alternative to AD recursive filter search ~"bug" as completed
Marked the task Seek alternative to AD recursive filter search ~"bug" as completed
- Author Maintainer
8.13 issues:
Features:
- CE/EE:LDAP failover configuration - https://gitlab.com/gitlab-org/gitlab-ee/issues/139
- EE: Allow membership override when using LDAP group sync (frontend) https://gitlab.com/gitlab-org/gitlab-ee/issues/343
Bug fixes:
-
EE: LDAP group option should not be displayed if
group_base
isn't set - https://gitlab.com/gitlab-org/gitlab-ee/issues/802 - CE/EE: Rake ldap:check seems to do anonymous bind - https://gitlab.com/gitlab-org/gitlab-ce/issues/21621
Documentation:
- EE: Document user_filter syntax - https://gitlab.com/gitlab-org/gitlab-ce/issues/21228
- EE: Document sync_ssh_keys feature https://gitlab.com/gitlab-org/gitlab-ce/issues/19236
Edited by Drew Blessing - Drew Blessing marked the checklist item Improve error message when LDAP user is outside filter ~bug customer as completed
marked the checklist item Improve error message when LDAP user is outside filter ~bug customer as completed
- Chris mentioned in issue #2522 (closed)
mentioned in issue #2522 (closed)
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- 🤖 GitLab Bot 🤖 removed [deprecated] Accepting merge requests label
removed [deprecated] Accepting merge requests label
- 🤖 GitLab Bot 🤖 added Manage [DEPRECATED] label
added Manage [DEPRECATED] label
- 🤖 GitLab Bot 🤖 added devopsmanage label
added devopsmanage label
- 🤖 GitLab Bot 🤖 added Enterprise Edition label
added Enterprise Edition label
- Drew Blessing closed
closed
- 🤖 GitLab Bot 🤖 mentioned in merge request !44478 (merged)
mentioned in merge request !44478 (merged)
- Bas Couwenberg mentioned in issue #276175 (closed)
mentioned in issue #276175 (closed)
- Taurie Davis mentioned in merge request !61791 (merged)
mentioned in merge request !61791 (merged)
- Ghost User mentioned in merge request !65227 (merged)
mentioned in merge request !65227 (merged)
- Sam White mentioned in issue #357297 (closed)
mentioned in issue #357297 (closed)
- Kent Jennings mentioned in issue #407349 (closed)
mentioned in issue #407349 (closed)
- Luca Romano mentioned in issue #414398
mentioned in issue #414398
- Meltory LLC mentioned in issue #457942 (closed)
mentioned in issue #457942 (closed)