Extract EE specific files/lines for spec/controllers/groups
We have the following files containing EE specific code. We should move them to ee/
spec/controllers/groups/boards_controller_spec.rb
diff --git a/spec/controllers/groups/boards_controller_spec.rb b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/controllers/groups/boards_controller_spec.rb
index 4228e727b52..d57479673c3 100644
--- a/spec/controllers/groups/boards_controller_spec.rb
+++ b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/controllers/groups/boards_controller_spec.rb
@@ -77,7 +77,7 @@ describe Groups::BoardsController do
context 'when format is JSON' do
it 'return an array with one group board' do
- create(:board, group: group)
+ create(:board, group: group, milestone: create(:milestone, group: group))
expect(Boards::Visits::LatestService).not_to receive(:new)
spec/controllers/groups/group_members_controller_spec.rb
diff --git a/spec/controllers/groups/group_members_controller_spec.rb b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/controllers/groups/group_members_controller_spec.rb
index 3a801fabafc..4a5d9c98787 100644
--- a/spec/controllers/groups/group_members_controller_spec.rb
+++ b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/controllers/groups/group_members_controller_spec.rb
@@ -54,6 +54,14 @@ describe Groups::GroupMembersController do
expect(group.users).to include group_user
end
+ it 'creates an audit event' do
+ expect do
+ post :create, params: { group_id: group,
+ user_ids: group_user.id,
+ access_level: Gitlab::Access::GUEST }
+ end.to change(AuditEvent, :count).by(1)
+ end
+
it 'adds no user to members' do
post :create, params: {
group_id: group,
@@ -174,6 +182,10 @@ describe Groups::GroupMembersController do
expect(response).to have_gitlab_http_status(200)
expect(json_response['notice']).to eq "You left the \"#{group.name}\" group."
end
+
+ it 'creates an audit event' do
+ expect { delete :leave, params: { group_id: group } }.to change(AuditEvent, :count).by(1)
+ end
end
context 'and is an owner' do
@@ -186,6 +198,10 @@ describe Groups::GroupMembersController do
expect(response).to have_gitlab_http_status(403)
end
+
+ it 'does not create an audit event' do
+ expect { delete :leave, params: { group_id: group } }.not_to change(AuditEvent, :count)
+ end
end
context 'and is a requester' do
@@ -201,6 +217,10 @@ describe Groups::GroupMembersController do
expect(group.requesters).to be_empty
expect(group.users).not_to include user
end
+
+ it 'creates an audit event' do
+ expect { delete :leave, params: { group_id: group } }.to change(AuditEvent, :count).by(1)
+ end
end
end
end
Edited by Yorick Peterse