Geo: Project sync failures usually double-increment `*_retry_count`
Summary
Project sync failures usually double-increment *_retry_count. Not a huge deal, but inaccurate and unexpected.
How
-
sync_repositorycallsfetch_repository -
fetch_repositorycallsupdate_registry!(started_at: DateTime.now) - We rescue certain exceptions in
sync_repositoryand callfail_registry! - Both
update_registry!andfail_registry!incrementrepository_retry_count/wiki_retry_count
TODO
-
Move update_registry!start call earlier to guarantee that it has been called by the timefail_registry!can be called -
Remove increment from fail_registry! -
Ensure in-progress syncs are not counted as failed (I think this bug was introduced while fixing this problem a long time ago)
Edited by Michael Kozono