Remove dead company-form onboarding leftovers
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Problem
!253445 (merged) removes CompanyController and its layers. CompanyController was the only caller of Onboarding::StatusStepUpdateService, and the deleted company view was the only consumer of a set of company-form predicate methods. Once that MR merges, this code has no remaining production callers.
Proposal
- Remove
Onboarding::StatusStepUpdateService(ee/app/services/onboarding/status_step_update_service.rb) and its spec - Remove
redirect_to_company_form?fromOnboarding::FreeRegistrationandOnboarding::TrialRegistration - Remove
show_company_form_side_column?andshow_company_form_footer?fromOnboarding::TrialRegistrationandOnboarding::AutomaticTrialRegistration - Remove the matching
delegatelines inee/app/presenters/ee/onboarding/status_presenter.rb - Remove the specs covering all of the above
Notes
Onboarding::AutomaticTrialRegistration itself is still live: Onboarding::UserStatus#registration_type returns it for the free-to-trial conversion path. Only its two company-form predicate overrides are dead, not the class itself.
Blocked on !253445 (merged) merging first.
Edited by 🤖 GitLab Bot 🤖