Rephrase sentences with a trailing URL in CE token and SSH key plain-text emails
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
!254859 (merged) fixed a 404 in several CE plain-text emails by removing the period after the settings URL. The resulting sentences end with a colon and a bare URL, for example:
You can create a new one or check them in your personal access tokens settings: %{pat_link}
During Technical Writing review of the EE follow-up !255638 (merged), @eread suggested rephrasing such sentences so the URL sits mid-sentence and the sentence keeps its closing period, for example Go to %{target_url} to update the secret. The same change should be applied to the CE templates under app/views/notify/:
access_token_about_to_expire_email.text.erbaccess_token_expired_email.text.erbaccess_token_revoked_email.text.erbaccess_token_created_email.text.erbaccess_token_rotated_email.text.erbbot_resource_access_token_about_to_expire_email.text.erbdeploy_token_about_to_expire_email.text.erbssh_key_expired_email.text.erbssh_key_expiring_soon_email.text.erb
The last four templates were not touched by the MR above but use the same colon style. locale/gitlab.pot needs to be updated accordingly.