Fix trailing punctuation after settings URLs in EE plain-text emails

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

In plain-text notification emails, a settings or action URL that is followed directly by punctuation can get that punctuation included in the link by some email clients, leading to a 404 when the link is clicked. This was fixed for several CE templates in !254859 (merged), which replaced the affected strings with a single translatable sentence using a colon before the URL placeholder, for example:

_('You can create a new one or check them in your personal access tokens settings: %{target_url}') % { target_url: @target_url }

Three EE templates have the same problem and were left out of that MR because they belong to other feature areas:

  • ee/app/views/notify/user_auto_banned_email.text.erb: two sentences end with %{url}.
  • ee/app/views/notify/group_secret_rotation_reminder_email.text.erb: uses You can update the secret at: %{target_url}!, with an exclamation mark right after the URL
  • ee/app/views/notify/project_secret_rotation_reminder_email.text.erb: same string and same issue as above

Proposed fix: update each string so the URL ends the sentence with no trailing punctuation, following the same convention as the merge request above, and update locale/gitlab.pot accordingly.

Edited by 🤖 GitLab Bot 🤖