[FF] duo_code_review_standard_flow - Rollout
Summary
Roll out the feature currently behind the duo_code_review_standard_flow feature flag (named duo_code_review_deep_flow until !270392 (merged)).
- DRI: @kinsingh
- Team Slack channel:
#g_code_review
Note
Process and guidance live in the docs, this issue is just the commands and a place to track the rollout. "Rolling out" means incrementally enabling the flag on GitLab.com to validate stability, it is not the same as releasing the feature, which happens when the flag is removed. Feature flag controls · Feature flag lifecycle
Rollout
Run all production /chatops in #production and cross-post the results to #g_code_review. Background: incremental rollout process, feature actors.
Before enabling for anyone, confirm all prerequisites are deployed:
- Monolith MR !253786 (merged) deployed to production. Without this, the flag does not exist.
- Monolith MR !253794 (merged) deployed to production. This adds
Gitlab::Duo::CodeReview::FindingsParser. It ships in a separate deploy from the flag above, so check it separately: with the ai-assist MR below already deployed and this one not, a review publishes zero comments and the author gets the "nothing to comment on" note. - ai-assist MR gitlab-org/modelops/applied-ml/code-suggestions/ai-assist!6773 (merged) deployed to the GitLab-managed AI Gateway / Duo Workflow Service fleet. Enabling before this MR is deployed means the flow posts XML, which still works.
- Monolith MR !255489 (merged) deployed to production. This renames the
duo_code_review_advanced_flowfeature flag toduo_code_review_deep_flowand theadvanced_code_reviewflow todeep_code_review. The AI gateway half (gitlab-org/modelops/applied-ml/code-suggestions/ai-assist!6932 (merged)) is already merged, but until this one is deployed the flag does not exist under its new name and any chatops command using it will fail. - Monolith MR !270392 (merged) deployed to production. This renames the
duo_code_review_deep_flowfeature flag toduo_code_review_standard_flowand thedeep_code_reviewflow tostandard_code_review, with the depths now called Lite and Standard. The AI gateway half (gitlab-org/modelops/applied-ml/code-suggestions/ai-assist!7985 (merged)) and the CustomersDot half (https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/17951) are already in production.
Non-production
/chatops gitlab run feature set duo_code_review_standard_flow true --dev --pre --staging --staging-refProduction
This rollout is actor based, not percentage based. The flag is checked on the project's root group (since !268225 (merged)), so enabling it for a user does nothing. Enable it for the gitlab-org and gitlab-com groups to cover internal reviews.
Renaming the flag does not carry over its enabled state. Every group that had duo_code_review_deep_flow enabled needs to be enabled again on duo_code_review_standard_flow, and the old flag should be disabled.
/chatops gitlab run feature set --group=gitlab-org duo_code_review_standard_flow true/chatops gitlab run feature set --group=gitlab-com duo_code_review_standard_flow trueA global percentage rollout is not planned. See "Before global rollout" below.
Before global rollout
Confirm the relevant gotchas before going to 100%, see enabling a feature for GitLab.com:
- Docs + version history updated
- Breaking changes announced, if any
- Change management issue opened, if required
- External API consumers handled with a fail-open mechanism, if applicable
No global rollout is planned before the flow is renamed and a production min_confidence is chosen. Tracked in #627791 (closed).
Cleanup
The flag is expected to be replaced by a user-facing depth setting, with levels "Lite" and "Standard", or removed once the Standard review becomes the default, pending the UX work in gitlab-org#23492 (closed).
Remove the flag and its YAML definition from the codebase, then:
/chatops gitlab run release check <merge-request-url> <milestone>
/chatops gitlab run feature delete duo_code_review_standard_flow --dev --pre --staging --staging-ref --productionRollback
/chatops gitlab run feature set duo_code_review_standard_flow false # production
/chatops gitlab run feature set duo_code_review_standard_flow false --dev --pre --staging --staging-ref # non-production
/chatops gitlab run feature delete duo_code_review_standard_flow --dev --pre --staging --staging-ref --production # remove entirely