Migrate Code Review Analytics to Vue 3
Migrate the Code Review Analytics page entrypoint(s) to Vue 3 behind a feature flag.
Docs: Code Review Analytics
Scope
This issue covers only the flag-gated rollout switch from Option 1 of the Vue 3 migration guide: add a single feature flag, add a vue3_migration.yml per entrypoint, and smoke test the affected pages. Full Vue 3 compliance (fixing compatibility issues, migrating unit tests) is not required here. Capture anything found during smoke testing in follow-up issues instead.
Implementation plan
1. Add the feature flag
Create vue3_migrate_code_review_analytics using bin/feature-flag:
type: beta,default_enabled: false,group: group::optimize- Read the
milestonevalue from theVERSIONfile - Set
feature_issue_urlto this issue - Use
useras the feature flag actor during rollout - Create a rollout issue from the "Feature Flag Roll Out" template and link it as
rollout_issue_url - Link the rollout issue to the parent epic gitlab-org&23041
2. Add a vue3_migration.yml per entrypoint
Create this file next to each index.js listed below:
status: rollout
feature_flag: vue3_migrate_code_review_analytics
group: group::optimize
migration_issue: https://gitlab.com/gitlab-org/gitlab/-/issues/614007Entrypoints:
-
ee/app/assets/javascripts/pages/projects/analytics/code_reviews/index/index.js(EE, project level, served byProjects::Analytics::CodeReviewsController#index)
Note: The page requires the
code_review_analyticslicensed feature (Premium and Ultimate). Smoke test with a project under a Premium or Ultimate license, otherwise the controller blocks access.
3. Document existing test coverage in the MR
- Add a section to the MR description listing which functionality of the feature is currently tested and where those tests are located, as in this example
4. Smoke test
Enable the flag locally and confirm the browser console logs [gitlab] [V] Using Vue.js 3 on each page, then verify the key workflows:
- Merge requests in review table renders with review time, author, approvers, comments, commits, and line change columns
- Filtering by milestone and label updates the table and total count
- Paginating through merge requests loads the next page
5. Follow-ups
- Open follow-up issues for any Vue 3 compatibility problems found during smoke testing and link them here
References
- Vue 3 migration guide, Option 1 (recommended)
- Example migration MR: gitlab-org/gitlab!247789
- Parent epic: gitlab-org&23041