[FF] dependency_management_persisted_remediations -- read auto-remediation dismissals from the remediations table
Summary
Roll out the persisted remediation dismissal read currently behind the dependency_management_persisted_remediations feature flag, introduced in !248943 (merged).
The exact-version dismissal rule is not part of this rollout. It gets its own flag and rollout issue.
- DRI: @albi.yusupova
- Team Slack channel:
#g_secure-composition-analysis
Note
Process and guidance live in the docs - this issue is just the commands and a place to track the rollout. "Rolling out" means incrementally enabling the flag on GitLab.com to validate stability - it is not the same as releasing the feature, which happens when the flag is removed. Feature flag controls · Feature flag lifecycle
What could go wrong?
With the flag on, auto-remediation decides whether a maintainer already dismissed a dependency bump by reading dependency_management_remediations as well as merge request history. A wrong row means a security merge request that should be opened is not, and it fails silently: no error, no unusual log line, just an absent merge request. The vulnerability itself stays visible in the vulnerability report, so it is detectable, but not from remediation logs alone.
Blast radius is limited to projects with an auto-remediation scan profile attached. The merge request history check remains underneath the record check, so turning the flag off restores the pre-table behaviour exactly.
The write path (!248938 (merged)) is not behind the flag, so rows accumulate regardless of its state. This flag gates only whether those rows are acted on.
Rollout
Run all production /chatops in #production and cross-post the results to the team channel.
Non-production
/chatops gitlab run feature set dependency_management_persisted_remediations 50 --actors --dev --pre --staging --staging-ref
/chatops gitlab run feature set dependency_management_persisted_remediations true --dev --pre --staging --staging-refProduction - start with a project we control, then percentage rollout (wait ≥15 min between steps):
/chatops gitlab run feature set --project=gitlab-org/secure/tests/albi.yusupova/persisted-ar-on dependency_management_persisted_remediations true
/chatops gitlab run feature set dependency_management_persisted_remediations <percentage> --actorsBefore global rollout
- Confirm dismissals made before the table shipped are still honoured, which exercises the merge request history fallback (result)
- Confirm a merge request deleted rather than closed does not resurface, the case the fallback cannot handle (result)
- Confirm a close that is not a user's decision still gets re-proposed. There is no
auto_closedstate: a close by the bot, by no one, or through a deleted source branch leaves the rowopen. The flag only adds reads ofdismissedrows, so it cannot block these.
Cleanup
Remove the flag once deemed stable, planned for 19.7. Keep the merge request history fallback in RemediationDismissalChecker and UserClosedRemediationsFinder. Task 5 of the exact-version dismissal issue removes it once the dismissal backfill has finalized, so dismissals predating the table survive on every instance.
/chatops gitlab run release check <merge-request-url> <milestone>
/chatops gitlab run feature delete dependency_management_persisted_remediations --dev --pre --staging --staging-ref --productionRollback
/chatops gitlab run feature set dependency_management_persisted_remediations false
/chatops gitlab run feature set dependency_management_persisted_remediations false --dev --pre --staging --staging-ref