Feature library modal: navigation & a11y polish (follow-ups from !248621)
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Summary
Two nice-to-have enhancements raised during review of !248621 (merged) (accessibility + Enter-key follow-ups in the Gemini search section of feature_library_modal.vue). Both are beyond that MR's scope (search box / Gemini section) and land in the broader modal-navigation UX.
Items
1. ArrowDown to move focus into results
Raised in !248621 (note).
The modal's Enter-key behavior (focus the first search result) is currently undiscoverable, and ArrowDown — the key used to move focus into results elsewhere in the codebase (modal_keyboard_navigation_mixin.js, file_tree_search.vue) — does nothing here. The sibling global search teaches its keys via an sr-only aria-describedby hint on the input (global_search.vue#L507-509).
Suggestion: bind @keydown.down to the same focus handler as Enter, and add a describedby hint on the search input.
2. Counted success announcement for Gemini results
Raised in !248621 (note).
The Gemini live-region success message ("Gemini found matching features.") reads the same whether there's 1 result or 20. The sibling global search announces a count (global_search.vue searchResultsDescription).
Suggestion: n__('FeatureLibrary|Gemini found %d matching feature.', 'FeatureLibrary|Gemini found %d matching features.', geminiItems.length). This is a product-copy call.
Context
- File:
app/assets/javascripts/super_sidebar/components/feature_library/feature_library_modal.vue - Raised by @anasshahid during review of !248621 (merged)
- @anasshahid — flagging in case this fits into the personal-navigation project work; feel free to reprioritize or fold in as you see fit.