Pass skip_ci to CreateBranchWorker for first mirror sync (follow-up to !247467)

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Summary

This is a follow-up to !247467 (merged) which adds the skip_ci parameter to Repositories::CreateBranchWorker but does not yet pass it from callers.

Per Sidekiq compatibility guidelines, adding a new worker argument requires a multi-release deployment:

Release Changes
19.3 (!247467 (merged)) Worker: Add skip_ci = false parameter (backwards compatible)
19.4 (this issue) Caller: Start passing skip_ci argument

What needs to be done

In ee/app/services/projects/update_mirror_service.rb:

  1. Pass skip_ci: skip_ci_for_non_default_branches? to bulk_create calls (lines ~197, ~206)
  2. Pass skip_ci in arguments_proc for schedule_async_batches (line ~254)

The skip_ci_for_non_default_branches? method and feature flag skip_pipelines_for_mirror_first_sync_non_default_branches are already in place from !247467 (merged).

Tests to add

Re-add the tests that verify skip_ci is passed to workers:

  • Test that bulk_create receives skip_ci: true on first sync
  • Test that bulk_create receives skip_ci: false on delta sync
  • Test that async workers receive skip_ci in arguments_proc

Related

  • Parent issue: #598486
  • Preparatory MR: !247467 (merged)
  • Feature flag: skip_pipelines_for_mirror_first_sync_non_default_branches
Edited by 🤖 GitLab Bot 🤖