Remove accessibleDisabledButton config wiring after @gitlab/ui makes aria-disabled the GlButton default

Summary

Follow-up to the accessible_disabled_button feature flag cleanup (#600158 (closed), now closed).

The FF cleanup MR (!247432 (merged)) removes the feature flag but intentionally keeps the glButtonConfig.accessibleDisabledButton config wiring in app/assets/javascripts/commons/gitlab_ui.js, hard-set to true. This is required because GlButton still reads that config value to determine whether to render aria-disabled instead of the native disabled attribute.

Removing the config wiring now would regress every disabled GlButton back to the native disabled attribute (inaccessible).

Blocked on

This work is blocked on @gitlab/ui shipping a version where aria-disabled="true" is the default behavior on GlButton when disabled — no config or flag needed. Once that ships and gitlab-org/gitlab bumps to it, the config wiring becomes safe to remove.

Version context:

  • @gitlab/ui 135.0.0 — currently pinned in gitlab-org/gitlab; still requires glButtonConfig.accessibleDisabledButton: true to enable the accessible behavior.
  • Target version — not yet released. This issue cannot proceed until it ships and GitLab bumps to it.

What to do (once @gitlab/ui makes aria-disabled the default)

  • Confirm the pinned @gitlab/ui version in package.json includes the change (aria-disabled is now the internal default on GlButton).
  • Remove the accessibleDisabledButton key from app/assets/javascripts/commons/gitlab_ui.js (currently hard-set to true).
  • Verify no visual/behavioral regression for disabled buttons.

Related

Edited by Adam Ferch