Top Level Group Duo settings cannot be edited if custom agents/flows or external agent settings are disabled for the instance

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Summary

If the Custom Flows, Custom Agents or External Agents are disabled in the GitLab Duo configuration for an instance, it makes it impossible to change any Duo related settings for a top-level group.

When the settings are changed in the UI, the user will see:

An error occurred while retrieving your settings. Reload the page to try again.

Steps to reproduce

  1. On an 19.1 instance, create a top-level group
  2. Navigate to Duo Configuration and disable External Agents, Custom Agents and Custom Flows
  3. Navigate to the top-level group created in Step 1
  4. Try to adjust any Duo setting for the group
  5. Observe An error occurred while retrieving your settings. Reload the page to try again. error returned.

Example Project

N/A

What is the current bug behavior?

When Custom Agents, Custom Flows or External Agents are disabled on an instance, it is not possible to set any Duo settings for a top-level group.

What is the expected correct behavior?

Other Duo settings for the top-level group should be able to be enabled/disabled as expected.

Relevant logs and/or screenshots

Top Level Group

image

Instance Settings

image

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Possible fixes

Patch release information for backports

If the bug fix needs to be backported in a patch release to a version under the maintenance policy, please follow the steps on the patch release runbook for GitLab engineers.

Refer to the internal "Release Information" dashboard for information about the next patch release, including the targeted versions, expected release date, and current status.

High-severity bug remediation

To remediate high-severity issues requiring an internal release for single-tenant SaaS instances, refer to the internal release process for engineers.

Edited by 🤖 GitLab Bot 🤖