Overriding ldap user permissions disables permissions menu permanently

Summary

Overriding ldap user permissions removes pencil-icon and disables the dropdown menu next to it, making it impossible to select the revert to ldap group sync settings later on.

Steps to reproduce

Select a ldap user within a group and choose to override his permissions set by ldap sync settings (e.g. Developer -> owner).

Example Project

no example possible

What is the current bug behavior?

• pencil-icon (edit) button removed after overriding permissions
• dropdown-menu for permissions disabled

What is the expected correct behavior?

• ability to select revert to ldap group sync settings to undo the change

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

System information
System:         Ubuntu 16.04
Proxy:          no
Current User:   git
Using RVM:      no
Ruby Version:   2.3.6p384
Gem Version:    2.6.13
Bundler Version:1.13.7
Rake Version:   12.3.0
Redis Version:  3.2.11
Git Version:    2.14.3
Sidekiq Version:5.0.5
Go Version:     unknown
GitLab information
Version:        10.5.8-ee
Revision:       faa84d5
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     postgresql
DB Version:     9.6.5
URL:            https://myhost.local
HTTP Clone URL: https://myhost.local/some-group/some-project.git
SSH Clone URL:  git@mygitlab.local:some-group/some-project.git
Elasticsearch:  no
Geo:            no
Using LDAP:     yes
Using Omniauth: no
GitLab Shell
Version:        6.0.3
Repository storage paths:

• default: /data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check

Checking GitLab Shell ...
GitLab Shell version >= 6.0.3 ? ... OK (6.0.3)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:root, or git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
14/3 ... ok
8/6 ... ok
17/7 ... repository is empty
30/12 ... ok
30/13 ... ok
32/14 ... ok
33/15 ... ok
34/16 ... ok
34/17 ... ok
30/18 ... ok
42/19 ... ok
43/20 ... ok
43/21 ... ok
43/22 ... ok
40/23 ... ok
38/24 ... ok
41/25 ... ok
41/27 ... ok
41/28 ... ok
41/29 ... ok
41/30 ... ok
41/31 ... ok
41/32 ... ok
41/33 ... ok
41/34 ... ok
41/35 ... ok
41/36 ... ok
41/37 ... ok
41/38 ... ok
41/39 ... ok
41/40 ... ok
41/41 ... ok
41/42 ... ok
38/47 ... ok
41/48 ... ok
41/49 ... ok
41/50 ... ok
41/51 ... ok
36/52 ... ok
41/53 ... ok
41/54 ... ok
41/55 ... ok
41/56 ... ok
41/57 ... ok
41/58 ... ok
41/59 ... ok
41/60 ... ok
30/61 ... ok
8/63 ... ok
41/65 ... ok
41/66 ... ok
41/68 ... ok
41/69 ... ok
43/70 ... ok
41/71 ... ok
41/72 ... ok
37/73 ... ok
41/74 ... ok
37/75 ... ok
41/76 ... ok
41/77 ... ok
55/78 ... ok
51/79 ... ok
51/81 ... repository is empty
8/82 ... ok
62/84 ... repository is empty
63/85 ... repository is empty
41/86 ... ok
41/88 ... ok
41/91 ... ok
48/92 ... ok
41/93 ... ok
30/94 ... ok
37/95 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml
Checking LDAP ...
Server: ldapmain
LDAP authentication... Success
LDAP users with access to your GitLab server (only showing the first 100 results)
satanized
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
14/3 ... yes
8/6 ... yes
17/7 ... yes
30/12 ... yes
30/13 ... yes
32/14 ... yes
33/15 ... yes
34/16 ... yes
34/17 ... yes
30/18 ... yes
42/19 ... yes
43/20 ... yes
43/21 ... yes
43/22 ... yes
40/23 ... yes
38/24 ... yes
41/25 ... yes
41/27 ... yes
41/28 ... yes
41/29 ... yes
41/30 ... yes
41/31 ... yes
41/32 ... yes
41/33 ... yes
41/34 ... yes
41/35 ... yes
41/36 ... yes
41/37 ... yes
41/38 ... yes
41/39 ... yes
41/40 ... yes
41/41 ... yes
41/42 ... yes
38/47 ... yes
41/48 ... yes
41/49 ... yes
41/50 ... yes
41/51 ... yes
36/52 ... yes
41/53 ... yes
41/54 ... yes
41/55 ... yes
41/56 ... yes
41/57 ... yes
41/58 ... yes
41/59 ... yes
41/60 ... yes
30/61 ... yes
8/63 ... yes
41/65 ... yes
41/66 ... yes
41/68 ... yes
41/69 ... yes
43/70 ... yes
41/71 ... yes
41/72 ... yes
37/73 ... yes
41/74 ... yes
37/75 ... yes
41/76 ... yes
41/77 ... yes
55/78 ... yes
51/79 ... yes
51/81 ... yes
8/82 ... yes
62/84 ... yes
63/85 ... yes
41/86 ... yes
41/88 ... yes
41/91 ... yes
48/92 ... yes
41/93 ... yes
30/94 ... yes
37/95 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.5 ? ... yes (2.3.6)
Git version >= 2.9.5 ? ... yes (2.14.3)
Git user has default SSH configuration? ... yes
Active users: ... 39
Elasticsearch version 5.1 - 5.5? ... skipped (elasticsearch is disabled)
Checking GitLab ... Finished

Possible fixes

Don't add disabled attribute to html dropdown-menu.