Follow-up from "Create push pipelines for approval policy bypass"
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
The following discussions from !238818 (merged) should be addressed:
-
@hfyngvason started a discussion:
Not blocking: I'm happy to move forward with this fix, but I think there are still a couple of gaps:
- Child pipelines. They are started lazily and won't have access to the push options.
- Similarly, manual jobs and delayed jobs may not know about the override
I think the override decision needs to be recorded with the push/pipeline. But this is significantly more complex and can be a follow-up.
-
@hfyngvason started a discussion:
Not blocking: Should there be a similar override for tags?
-
@hfyngvason started a discussion:
Not blocking:
Gitlab::UserAccess#can_run_pipeline_on_branch?could be a better fit here. It opens up the path for re-use in other contexts, such as manual jobs and delayed jobs onpushpipelines (see my other comment).