Follow-up from "Add DAP disabled empty state for non-admins"
The following discussions from !228881 (merged) should be addressed:
-
@dstull started a discussion: (+2 comments)
nitpick (non-blocking):
I'd rather not name things helper that aren't rails helpers as it is an overloaded term in rails.
-
@dstull started a discussion: (+1 comment)
issue:
We should avoid customizing gl-cards too much as per guides as it tends to break the design. In this case the
gl-p-0or such is breaking the border on the rounded corners -
@dstull started a discussion:
issue (non-blocking):
The core problem that is causing us to do this is that the testing is based on a
sendtocomponent_instanceand that conflicts with the our guidance herein a follow-up we should modify this entire spec file to use
render_inline -
@dstull started a discussion: (+2 comments)
suggestion (non-blocking):
describe should be for methods and context should be used for things like this. See https://www.betterspecs.org/ for better guidance.
-
@dstull started a discussion: (+2 comments)
question:
Why is
duo_ui_nextdisabled here? I'm fearful of what this means for our feature when it is enabled and we are disabling it here. Can you check? -
@dstull started a discussion: (+2 comments)
question (non-blocking):
If we do not concern ourselves with saas vs self-managed, as we discussed syncronously, could this be inlined?
