Follow-up from "Add "ci_runner_controller_runner_scopings" table"

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Collaborate/take over this issue

The following discussions from !221277 (merged) should be addressed:

• @takax started a discussion:

  @tigerwnz Could you double-check if this is right? 🙏

  At first, I tried to create FK for each partition table (like Create ci_runner_taggings table (!170778 - merged)), but it resulted an error because it's missing FK for the parent table. Finally, I used this add_concurrent_partitioned_foreign_key and it looks like it automatically creates necessary FKs. (But, I can find only one FK in db/structure.sql so, I'm a bit worrying if this is correct.)

• @OmarQunsulGitlab started a discussion:

  non-blocking. What I usually see in the code that if we have a unique index on [A, B, C], we validate the uniqueness of C within the scope of [A, B]. I am not sure if this makes a difference on the queries though. Because we have an index on [:runner_controller_id, :runner_id, :runner_type], So Probably this should have been validates :runner_type, uniqueness: { scope: [:runner_controller_id, :runner_id] }

  But since it makes sense no different to my knowledge, it's a complete nit-pick, considering that everything else in the code looks good