Resolve non-auto-correctable RuboCop offenses (Exclude-only) in .rubocop_todo/**/*.yml
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Problem
.rubocop_todo/**/*.yml contains non-auto-correctable
grep --recursive --files-without-match --null "Cop supports --autocorrect" .rubocop_todo/ | while IFS= read -r -d '' cop_file; do
cop_name="$(head -n 2 "$cop_file" | tail -n 1 | grep --color=never --only-match --perl-regexp "^[a-zA-Z/]+")"
num_exclusions=$(grep -c -- " - " "$cop_file")
printf -- '- [`%s`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/%s) (%d entries, [chart](https://ck3g.gitlab.io/rubocop-burndown/#%s))\n' "$cop_name" "$cop_file" "$num_exclusions" "$cop_name"
done | sortImplementation guide
Same as #239356, but instead of rubocop --autocorrect, find the corresponding RuboCop in https://gitlab.com/gitlab-org/gitlab/-/tree/master/rubocop/cop to view the requirements, and then manually fix the issue.
The List
API/DescriptionDetail(65 entries, chart)API/DescriptionFailureResponse(153 entries, chart)API/DescriptionSuccessResponse(64 entries, chart)API/ParameterDescription(7 entries, chart)API/ParameterDocumentation(7 entries, chart)API/ParameterType(7 entries, chart)Cop/UserAdmin(24 entries, chart)Database/AvoidInheritanceColumn(2 entries, chart)Database/AvoidScopeTo(7 entries, chart)Database/AvoidUsingConnectionExecute(37 entries, chart)Database/AvoidUsingPluckWithoutLimit(134 entries, chart)Database/JsonbSizeLimit(75 entries, chart)Database/RescueQueryCanceled(2 entries, chart)FactoryBot/ExcessiveCreateList(33 entries, chart)Fips/MD(10 entries, chart)Fips/SHA(86 entries, chart)Gitlab/Authz/DisallowAbilityAllowed(12 entries, chart)Gitlab/Authz/PermissionCheck(790 entries, chart)Gitlab/Authz/RoleCheckInRule(6 entries, chart)Gitlab/AvoidConstDefaultOrganizationId(17 entries, chart)Gitlab/AvoidDefaultOrganization(9 entries, chart)Gitlab/AvoidDirectWorkItemTypeUsage(6 entries, chart)Gitlab/AvoidGitlabDedicatedInstanceChecks(18 entries, chart)Gitlab/AvoidGitlabInstanceChecks(67 entries, chart)Gitlab/AvoidProjectIssuableUrlHelpers(12 entries, chart)Gitlab/AvoidOrganizationUrlRoutes(1 entries, chart)Gitlab/AvoidUserOrganization(10 entries, chart)Gitlab/BoundedContexts(4000 entries, chart)Gitlab/DirectStdio(8 entries, chart)Gitlab/DocumentationLinks/HardcodedUrl(24 entries, chart)Gitlab/EeOnlyClass(39 entries, chart)Gitlab/EventStoreCloudEventInheritance(106 entries, chart)Gitlab/FeatureAvailableUsage(94 entries, chart)Gitlab/FeatureFlagWithoutActor(124 entries, chart)Gitlab/HardDeleteCalls(5 entries, chart)Gitlab/NamespacedClass(1166 entries, chart)Gitlab/NoCodeCoverageComment(7 entries, chart)Gitlab/NoFindInWorkers(71 entries, chart)Gitlab/NoHelpersInPresenters(25 entries, chart)Gitlab/PreventOrganizationFirst(7 entries, chart)Gitlab/RSpec/MisplacedEeSpecFile(227 entries, chart)Gitlab/ServiceResponse(67 entries, chart)Gitlab/TokenWithoutRoutable(14 entries, chart)Gitlab/UsersInternalOrganization(4 entries, chart)GitlabSecurity/PublicSend(5 entries, chart)GraphQL/ArgumentUniqueness(1 entries, chart)GraphQL/ExtractType(99 entries, chart)GraphQL/GraphqlName(130 entries, chart)Graphql/AuthorizeTypes(4 entries, chart)Graphql/EnumNames(33 entries, chart)Graphql/EnumValues(32 entries, chart)InternalAffairs/OnSendWithoutOnCSend(119 entries, chart)InternalAffairs/UselessMessageAssertion(32 entries, chart)Lint/ConstantDefinitionInBlock(29 entries, chart)Lint/DuplicateBranch(12 entries, chart)Lint/DuplicateMethods(4 entries, chart)Lint/EmptyBlock(105 entries, chart)Lint/MissingCopEnableDirective(113 entries, chart)Mcp/UseGraphqlQueryFile(0 entries, chart)Metrics/AbcSize(5 entries, chart)Metrics/CyclomaticComplexity(11 entries, chart)Metrics/ParameterLists(4 entries, chart)Metrics/PerceivedComplexity(8 entries, chart)Migration/BackgroundMigrationRecord(10 entries, chart)Migration/BatchedMigrationBaseClass(14 entries, chart)Naming/HeredocDelimiterNaming(6 entries, chart)Performance/ActiveRecordSubtransactionMethods(36 entries, chart)Performance/CollectionLiteralInLoop(28 entries, chart)RSpec/AvoidConditionalStatements(55 entries, chart)RSpec/AvoidWaitForRequests(593 entries, chart)RSpec/BeforeAllRoleAssignment(824 entries, chart)RSpec/ContextWording(2603 entries, chart)RSpec/ExampleWithoutDescription(484 entries, chart)RSpec/ExpectInHook(389 entries, chart)RSpec/ExpectInLet(19 entries, chart)RSpec/FactoryBot/AvoidCreate(520 entries, chart)RSpec/FactoryBot/StrategyInCallback(45 entries, chart)RSpec/FeatureCategory(2904 entries, chart)RSpec/FeatureSpecMaxExamples(40 entries, chart)RSpec/IdenticalEqualityAssertion(24 entries, chart)RSpec/InstanceVariable(108 entries, chart)RSpec/MissingExampleGroupArgument(12 entries, chart)RSpec/MissingExpectationTargetMethod(12 entries, chart)RSpec/MultipleMemoizedHelpers(33 entries, chart)RSpec/NamedSubject(3077 entries, chart)RSpec/NoExpectationExample(143 entries, chart)RSpec/OverwritingSetup(4 entries, chart)RSpec/PendingWithoutReason(20 entries, chart)RSpec/RailsControllerTesting(284 entries, chart)RSpec/RepeatedExampleGroupBody(38 entries, chart)RSpec/RepeatedExampleGroupDescription(76 entries, chart)RSpec/RepeatedSubjectCall(56 entries, chart)RSpec/SpecFilePathFormat(63 entries, chart)RSpec/SpecFilePathSuffix(3 entries, chart)RSpec/SubjectDeclaration(88 entries, chart)RSpec/VerifiedDoubles(859 entries, chart)Rails/HelperInstanceVariable(67 entries, chart)Rails/InverseOf(71 entries, chart)Rails/LexicallyScopedActionFilter(39 entries, chart)Rails/OutputSafety(73 entries, chart)Rails/RequireDependency(29 entries, chart)Rake/Require(10 entries, chart)Rake/TopLevelMethodDefinition(43 entries, chart)Search/NamespacedClass(157 entries, chart)Security/CompoundHash(3 entries, chart)Sidekiq/EnforceDatabaseHealthSignalDeferral(187 entries, chart)SidekiqLoadBalancing/WorkerDataConsistency(330 entries, chart)Style/InlineDisableAnnotation(2197 entries, chart)Style/MissingRespondToMissing(16 entries, chart)Style/NumberedParameters(50 entries, chart)Style/OpenStructUse(9 entries, chart)Style/UnlessLogicalOperators(26 entries, chart)
Edited by Jonston Chan