Resolve non-auto-correctable RuboCop offenses (Exclude-only) in .rubocop_todo/**/*.yml
Problem
.rubocop_todo/**/*.yml contains non-auto-correctable
grep --recursive --files-without-match --null "Cop supports --autocorrect" .rubocop_todo/ | while IFS= read -r -d '' cop_file; do
cop_name="$(head -n 2 "$cop_file" | tail -n 1 | grep --color=never --only-match --perl-regexp "^[a-zA-Z/]+")"
num_exclusions=$(grep -c -- " - " "$cop_file")
printf -- '- [`%s`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/%s) (%d entries, [chart](https://ck3g.gitlab.io/rubocop-burndown/#%s))\n' "$cop_name" "$cop_file" "$num_exclusions" "$cop_name"
done | sortImplementation guide
Same as #239356, but instead of rubocop --autocorrect, find the corresponding RuboCop in https://gitlab.com/gitlab-org/gitlab/-/tree/master/rubocop/cop to view the requirements, and then manually fix the issue.
Burndown chart
The List
API/DescriptionDetail(21 entries, chart)API/DescriptionFailureResponse(151 entries, chart)API/DescriptionSuccessResponse(59 entries, chart)API/ParameterDocumentation(7 entries, chart)Cop/UserAdmin(24 entries, chart)Database/AvoidInheritanceColumn(1 entries, chart)Database/AvoidScopeTo(2 entries, chart)Database/AvoidUsingConnectionExecute(37 entries, chart)Database/AvoidUsingPluckWithoutLimit(132 entries, chart)Database/JsonbSizeLimit(72 entries, chart)FactoryBot/ExcessiveCreateList(8 entries, chart)Fips/MD(9 entries, chart)Fips/SHA(83 entries, chart)Gitlab/Ai/AvoidFoundationalFlowStringLookup(22 entries, chart)Gitlab/Authz/DisallowAbilityAllowed(12 entries, chart)Gitlab/Authz/PermissionCheck(765 entries, chart)Gitlab/Authz/RoleCheckInRule(5 entries, chart)Gitlab/AvoidConstDefaultOrganizationId(11 entries, chart)Gitlab/AvoidDefaultOrganization(8 entries, chart)Gitlab/AvoidDirectWorkItemTypeUsage(6 entries, chart)Gitlab/AvoidGitlabDedicatedInstanceChecks(17 entries, chart)Gitlab/AvoidGitlabInstanceChecks(66 entries, chart)Gitlab/AvoidOrganizationUrlRoutes(1 entries, chart)Gitlab/AvoidProjectIssuableUrlHelpers(11 entries, chart)Gitlab/AvoidUserOrganization(8 entries, chart)Gitlab/BoundedContexts(3968 entries, chart)Gitlab/DirectStdio(8 entries, chart)Gitlab/DocumentationLinks/HardcodedUrl(70 entries, chart)Gitlab/EeOnlyClass(39 entries, chart)Gitlab/EventStoreCloudEventInheritance(102 entries, chart)Gitlab/FeatureAvailableUsage(93 entries, chart)Gitlab/FeatureFlagWithoutActor(121 entries, chart)Gitlab/HardDeleteCalls(4 entries, chart)Gitlab/NamespacedClass(1158 entries, chart)Gitlab/NoCodeCoverageComment(7 entries, chart)Gitlab/NoFindInWorkers(71 entries, chart)Gitlab/NoHelpersInPresenters(25 entries, chart)Gitlab/PreventOrganizationFirst(7 entries, chart)Gitlab/RSpec/MisplacedEeSpecFile(226 entries, chart)Gitlab/Rails/EncryptsDeterministic(1 entries, chart)Gitlab/ServiceResponse(67 entries, chart)Gitlab/TokenWithoutRoutable(13 entries, chart)Gitlab/UsersInternalOrganization(4 entries, chart)GitlabSecurity/PublicSend(5 entries, chart)GraphQL/ArgumentUniqueness(1 entries, chart)GraphQL/ExtractType(99 entries, chart)GraphQL/GraphqlName(131 entries, chart)Graphql/AuthorizeTypes(4 entries, chart)Graphql/EnumNames(33 entries, chart)Graphql/EnumValues(32 entries, chart)InternalAffairs/OnSendWithoutOnCSend(119 entries, chart)InternalAffairs/UselessMessageAssertion(30 entries, chart)Lint/ConstantDefinitionInBlock(29 entries, chart)Lint/DuplicateBranch(12 entries, chart)Lint/DuplicateMethods(4 entries, chart)Lint/EmptyBlock(103 entries, chart)Lint/MissingCopEnableDirective(104 entries, chart)Metrics/AbcSize(5 entries, chart)Metrics/CyclomaticComplexity(11 entries, chart)Metrics/ParameterLists(4 entries, chart)Metrics/PerceivedComplexity(8 entries, chart)Migration/BackgroundMigrationRecord(4 entries, chart)Migration/BatchedMigrationBaseClass(5 entries, chart)Migration/ForeignKeysToDestroyServiceTables(2 entries, chart)Naming/HeredocDelimiterNaming(6 entries, chart)Performance/ActiveRecordSubtransactionMethods(36 entries, chart)Performance/CollectionLiteralInLoop(26 entries, chart)RSpec/AvoidConditionalStatements(53 entries, chart)RSpec/AvoidWaitForRequests(466 entries, chart)RSpec/BeforeAllRoleAssignment(646 entries, chart)RSpec/ContextWording(2582 entries, chart)RSpec/ExampleWithoutDescription(475 entries, chart)RSpec/ExpectInHook(388 entries, chart)RSpec/ExpectInLet(19 entries, chart)RSpec/FactoryBot/AvoidCreate(517 entries, chart)RSpec/FactoryBot/StrategyInCallback(42 entries, chart)RSpec/FeatureCategory(2686 entries, chart)RSpec/FeatureSpecMaxExamples(41 entries, chart)RSpec/IdenticalEqualityAssertion(24 entries, chart)RSpec/InstanceVariable(105 entries, chart)RSpec/MissingExampleGroupArgument(12 entries, chart)RSpec/MissingExpectationTargetMethod(12 entries, chart)RSpec/MultipleMemoizedHelpers(31 entries, chart)RSpec/NamedSubject(2888 entries, chart)RSpec/NoExpectationExample(140 entries, chart)RSpec/PendingWithoutReason(20 entries, chart)RSpec/RailsControllerTesting(279 entries, chart)RSpec/RepeatedExampleGroupDescription(67 entries, chart)RSpec/RepeatedSubjectCall(52 entries, chart)RSpec/SpecFilePathFormat(63 entries, chart)RSpec/SpecFilePathSuffix(3 entries, chart)RSpec/SubjectDeclaration(86 entries, chart)RSpec/VerifiedDoubles(848 entries, chart)Rails/HelperInstanceVariable(67 entries, chart)Rails/InverseOf(69 entries, chart)Rails/LexicallyScopedActionFilter(38 entries, chart)Rails/OutputSafety(69 entries, chart)Rails/RequireDependency(29 entries, chart)Rake/Require(10 entries, chart)Rake/TopLevelMethodDefinition(43 entries, chart)Search/NamespacedClass(154 entries, chart)Sidekiq/EnforceDatabaseHealthSignalDeferral(188 entries, chart)SidekiqLoadBalancing/WorkerDataConsistency(325 entries, chart)Style/InlineDisableAnnotation(2134 entries, chart)Style/MissingRespondToMissing(15 entries, chart)Style/NumberedParameters(47 entries, chart)Style/OpenStructUse(9 entries, chart)Style/UnlessLogicalOperators(21 entries, chart)
Edited by 🤖 GitLab Bot 🤖