Follow-up from "Add rotate endpoint for runner controller token"

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Label this issue

The following discussion from !217341 (merged) should be addressed:

• @hfyngvason started a discussion: (+2 comments)

  The ! on #revoke! is misleading. Normally, I would expect that to raise when invalid, but it uses #update under the hood. I think we should remove it from the name. Alternatively, you could change #revoke! to use #update!, but I think that would make the code here less clear.

  • A counterpoint was raised that this followed the example of app/models/clusters/agent_token.rb#L42-44). But that's a minority example. Most revoke! implementations raise exceptions. Both methods mentioned should be renamed or changed to raise exceptions.