Files selected in MRs in Firefox and Safari are not scrolled into view
Summary
Selecting a file from the Changes tab in a MR does not scroll the file into view in Firefox and Safari as expected.
Steps to reproduce
- In Firefox or Safari, open !217337 (diffs)
- In turn, click on the first four files in the changes.
Example Project
See the example MR in the GitLab project linked in the Steps to reproduce.
What is the current bug behavior?
Each file gets selected but is scrolled out of view. It has to manually be scrolled back into view.
What is the expected correct behavior?
Selecting a file should scroll to the top of that file, like it does in Chrome or Edge.
Relevant logs and/or screenshots
This video demonstrates the reproduction steps in Firefox:
Output of checks
This bug happens on GitLab.com
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: \\\`sudo gitlab-rake gitlab:env:info\\\`) (For installations from source run and paste the output of: \\\`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production\\\`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of: \`sudo gitlab-rake gitlab:check SANITIZE=true\`) (For installations from source run and paste the output of: \`sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true\`) (we will only investigate if the tests are passing)
Possible fixes
Patch release information for backports
If the bug fix needs to be backported in a patch release to a version under the maintenance policy, please follow the steps on the patch release runbook for GitLab engineers.
Refer to the internal "Release Information" dashboard for information about the next patch release, including the targeted versions, expected release date, and current status.
High-severity bug remediation
To remediate high-severity issues requiring an internal release for single-tenant SaaS instances, refer to the internal release process for engineers.