Follow-up from "Enforce instance-level Duo Agent Platform setting"

The following discussions from !216002 (merged) should be addressed:

  • @GitLabDuo started a discussion:

    Method name has a typo - there's an extra "enabled" in the name. This will prevent the setter from working correctly.

        def duo_agent_platform_enabled=(value)
  • @terrichu started a discussion:

    question (non-blocking): just want to confirm, _container is a placeholder for implementation for GitLab.com right? It'll be used in a future iteration?

  • @terrichu started a discussion:

    suggestion (non-blocking): you might choose feature name more related to duo. I looked at the feature options and gitlab_duo_saas_only seems like a better fit

  • @terrichu started a discussion:

    question (non-blocking): can the factory be used here instead?

  • @terrichu started a discussion:

    question: is the default for duo_agent_platform_enabled true? if so, I would suggest setting it to false for this spec only

  • @terrichu started a discussion:

    issue: the agentic catalog is still shown in the Search or go to with the setting off. Clicking it goes to a 404 (as Bonet pointed out above)

    image

  • @terrichu started a discussion: (+2 comments)

    @jessieay I left a few comments, most are non-blocking. The one issue I found I'll link to the spot where that code lives.

    Note: I'm out for a few days after today so you should pass to another backend reviewer

Edited by 🤖 GitLab Bot 🤖