Do not archive project when scheduling them for deletion

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Background

Scheduling a project for deletion would automatically put them into an archived state. Similarly, restoring them would put them back into an active state.

Proposal

Remove this behavior to keep archived as a separately managed state.

This is in line with the our state transitions where restoring a group/project would put it to its previous archived state.

This also helps simplify the work needed for &19690 (comment 2837069265)

Implementation Guide

  1. Remove archived param from the Projects::MarkedForDeletionService https://gitlab.com/gitlab-org/gitlab/blob/10e4358925268a03d59b0872a1abb0bf498b99e7/app/services/projects/mark_for_deletion_service.rb#L31
  2. Remove archived param from the Projects::RestoreService https://gitlab.com/gitlab-org/gitlab/blob/59ab07b022fde1f393aab872097847f8a747e411/app/services/projects/restore_service.rb#L33
  3. Update the specs accordingly
Edited by 🤖 GitLab Bot 🤖