Update the Danger database review bot to also ping when query scope is updated

Summary

We have existing tooling which automatically prompts MR authors to provide a Query Plan when a set of database changes matches conditions.

We should update this automation to ensure it pings authors with a prominent call to follow our Query Plan guidance when we change query scope as well. This was the root cause of the performance issue which prompted this work.

Implementation guide

  • Update the bot script conditions to trigger when query scope is modified or introduced
  • Create test MRs to verify the bot works as intended
  • Optional: update the bot messaging to add additional requests for detailed query plans (eg. more representative of real-world usage)
Edited by Matt Andrews