"resolved all threads" added to the history when someone approves, even if there are unresolved thread

Hi,

We are experiencing a small issue GitLab version v18.6.1, we are hosting GitLab.

Here is the issue, we are facing when an MR is being reviewed.

Here is the scenario:

  • someone opens a thread
  • the first thread is not resolved
  • someone approves the MR (it could be the same person)
  • the first thread is still there as not resolved.

The activity will report that all threads are resolved, while they are not.

image

It's a minor bug, I feel like the issue only occurs for a few recent versions.

Edited by 🤖 GitLab Bot 🤖