Prepare dast_profiles_tags before tags becomes Cell local
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Based on the following discussion: https://gitlab.com/gitlab-org/gitlab/-/issues/470872#note_2926166707, the dast_profiles_tags table is going to be org-wide and the tags table is going to be cell local. A challenge with doing this is that dast_profiles_tags references tags. So if tags moves to a different cell, there is a possibility that dast_profiles_tags starts referencing a non-existent tag and breaks existing DAST scans.
Currently the dast_profiles_tags table references the tags table only through tag_id. Based on the strategy being used by CI: #470872 (comment 2926166707)
CI is storing
tag_namein the referencing tables, in addition totag_id. So when these table rows are moved to another cell, the CItagstable row can be re-created if not present.
Hence, a reference to tag_name needs to be added to dast_profiles_tags so that the tags table row can be re-created if needed.
Effect on User Experience
Moving from storing
tag_idto storingtag_names. No breaking change here. Just a migrationRequest
tag_namesmay not match any runner on the Cell.
- If the user requests tag_names that matches their group / project runners, it's not an issue.
- If the user requests tag_names for hosted runners, then Yes. This might break some DAST scans. We should ask the CI Category:Fleet Visibility team ( groupci platform ?) if there's any standard list of tags we will always have available on all cells.