Geo Primary Verification: Match view controller error state to API error state for data management routes
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Summary
Follow-up to !214542 (merged)
When visiting the old route format (e.g., admin/data_management/upload), the API correctly returns a 400 error, but the view controller still returns 200. This creates confusion for users manipulating the URL.
Proposal
Update the view controller to reject improper routes with a 404 error to match the API behavior.
Suggested approach: Re-use AVAILABLE_MODEL_NAMES = Gitlab::Geo::ModelMapper.available_model_names.map(&:pluralize).freeze to validate routes in the controller.
Related
- Parent MR: !214542 (merged)
- Original comment: !214542 (comment 2925154101)
- Issue: #582209
Edited by 🤖 GitLab Bot 🤖