Make project management related project archival features compatible with group archival

Prerequisite

Before you start, please check out the parent epic description to get the full context: Make project archival features compatible with ... (&19690)

Description

We ran a search for "archive" and "archival" in the codebase and pulled together the following relevant results for the groupproject management domain. We'd need your help with:

1. Review the search results and update the code to use our new ancestor-aware methods and scopes wherever needed
2. Creating new services/workers wherever they're needed
3. Note: Not all "archive" mentions are about project archival – feel free to skip anything that's not relevant!

Archive/Archival Occurrences

Project Management

1. app/models/issue.rb

   • scope :non_archived, ->(use_existing_join: false) do
   • relation.where(project_id: nil).or(relation.where(projects: { archived: false }))

2. app/models/concerns/issuable.rb

   • scope :non_archived, -> { join_project.where(projects: { archived: false }) }

3. app/finders/issuable_finder.rb

   • # non_archived: boolean
   • items = by_non_archived(items)
   • def by_non_archived(items)
   • if params[:non_archived].present?
   • items.non_archived(use_existing_join: use_join_strategy_for_project?)
   • items.non_archived

4. app/graphql/resolvers/issues_resolver.rb

   • NON_FILTER_ARGUMENTS = %i[sort lookahead include_archived].freeze
   • argument :include_archived, GraphQL::Types::Boolean,
   • description: 'Whether to include issues from archived projects. Defaults to false.'
   • prepared[:non_archived] = !prepared.delete(:include_archived)

5. app/controllers/concerns/issues_calendar.rb

   • .non_archived

6. app/controllers/concerns/issuable_collections_action.rb

   • .non_archived
   • non_archived: true,

7. app/controllers/concerns/work_items_collections.rb

   • .non_archived

8. app/services/groups/open_issues_count_service.rb

   • non_archived: true,

9. app/services/boards/issues/list_service.rb

   • set_non_archived
   • def set_non_archived
   • params[:non_archived] = parent.is_a?(Group)

10. app/graphql/resolvers/namespaces/work_items_resolver.rb

    • include_archived
    • argument :include_archived, GraphQL::Types::Boolean,
    • description: 'Return work items from archived projects. Ignored for project namespaces.',
    • args[:non_archived] = !args.delete(:include_archived)

11. app/graphql/resolvers/concerns/group_issuable_resolver.rb

    • argument :include_archived, GraphQL::Types::Boolean,
    • description: "Return #{issuable_collection_name} from archived projects"
    • args[:non_archived] = !args.delete(:include_archived)

12. app/controllers/groups/work_items_controller.rb

    • @work_items = work_items_for_rss.non_archived

13. lib/gitlab/issuables_count_for_state.rb

    • attempt_group_search_optimizations non_archived issue_types lookahead exclude_projects

14. lib/api/issues.rb

    • optional :non_archived, type: Boolean, default: true,
    • desc: 'Return issues from non archived projects'
    • optional :non_archived, type: Boolean, desc: 'Return issues from non archived projects', default: true