Skip to content

Unblock fail-open rules outside of MergeRequest::CreatePipelineWorker

Why are we doing this work

In order to unblock fail_open MRAP approval rules, we currently enqueue UnblockFailOpenApprovalRulesWorker from an EE extension to MergeRequest::CreatePipelineWorker#after_perform. However there are call-sites of MergeRequests::CreatePipelineService which don't enqueue the worker. Meaning if one of these synchronous callers ends up not creating a pipeline, we don't unblock fail_open approval rules.

Relevant links

Non-functional requirements

  • Documentation:
  • Feature flag:
  • Performance:
  • Testing:

Implementation plan

TBD

Verification steps

TBD

Edited by Dominic Bauer