Callouts: remove unused exposed variables from the user_callout_dismisser.vue
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
In !169515 (comment 2821078311) we found that it seems that most of the slot variables, exposed by the user_callout_dismisser.vue component are not used. We expose:
{
dismiss,
isAnonUser,
isDismissed,
isLoadingMutation,
isLoadingQuery,
mutationError,
queryError,
shouldShowCallout,
}
And we also emit queryResult. But it seems like we only use dismiss and shouldShowCallout.
In the group callout we only exposed these two. It might make sense to limit them in the User callout too.
.
The following discussion from !169515 (merged) should be addressed:
-
@kpalchyk started a discussion: (+4 comments) suggestion: I searched the codebase, and it seems that for the user callout dismisser we don't consume anything but
dismissandshouldShowCallout.Nothing else, it seems. But please, double-check me here.
If that is the case, then we're overdelivering values that we need to support. I'd suggest dropping all other options, and create an issue to drop them from the original component too. We can always expose them later, but be flexible in the meanwhile.