Pipeline Editor Visualizer not displaying needs relationships

MR: Fix Pipeline Editor visualisation not displayin... (!209340 - merged) • Sahil Sharma • 18.6

Summary

The Visualizer in the Pipeline Editor is not functioning correctly:

1. needs relationships between jobs are not being displayed
2. Jobs without needs dependencies are not being greyed out as expected when the mouse is hovered above the needs jobs

Steps to reproduce

1. Navigate to Build > Pipeline Editor in a project
2. Create or edit a pipeline with jobs that have needs relationships defined
3. View the pipeline visualization
4. Observe that the dependency arrows/connections are missing
5. Observe that jobs without needs are not visually distinguished (greyed out)

Sample CI file:

stages:
  - build
  - test
  - deploy

build:app:
  stage: build
  script:
    - echo "Build"

test:app:
  stage: test
  needs:
    - build:app
  script:
    - echo "Test"

deploy:app:
  stage: deploy
  script:
    - echo "Deploy"

Example Project

This happens on GitLab.com

What is the current bug behavior?

Pipeline visualizer does not show needs relationships.

What is the expected correct behavior?

Pipeline visualizer should show needs relationships.

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

 (For installations with omnibus-gitlab package run and paste the output of: \`sudo gitlab-rake gitlab:env:info\`)  (For installations from source run and paste the output of: \`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production\`)  

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:check SANITIZE=true`)

(For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`)

(we will only investigate if the tests are passing)

Possible fixes

Patch release information for backports

If the bug fix needs to be backported in a patch release to a version under the maintenance policy, please follow the steps on the patch release runbook for GitLab engineers.

Refer to the internal "Release Information" dashboard for information about the next patch release, including the targeted versions, expected release date, and current status.

High-severity bug remediation

To remediate high-severity issues requiring an internal release for single-tenant SaaS instances, refer to the internal release process for engineers.