You need to sign in or sign up before continuing.
Docs: Clarify that "admins" sometimes means Owners and sometimes Owners+Maintainers
[x] Start this issue's title with Docs:
or Docs feedback:
.
Problem to solve
- What product or feature(s) affected? Compliance frameworks docs
- What docs or doc section affected? Compliance frameworks docs
- Is there a problem with a specific document, or a feature/process that's not addressed sufficiently in docs? Yes, some Compliance Controls use the word "admin" in the control name (e.g.
ensure_2_admins_per_repo
) and the explanatory text also uses the wordAdmin
but that is not a role in GitLab groups or projects.
Further details
N/a
Proposal
Update the docs to clearly indicate the actual GitLab roles that are checked.
Who can address the issue
Anyone can contribute
Other links/references
First bit. Here, "admins" = owners. Relevant code is: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/lib/compliance_management/compliance_requirements/project_fields.rb#L245-247
def ensure_2_admins_per_repo?(project, _context = {})
project.team.owners.count >= 2
end
Second bit. Here, "admins" = owners + maintainers. Relevant code is: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/lib/compliance_management/compliance_requirements/project_fields.rb#L229-235
def more_members_than_admins?(project, _context = {})
team = project.team
return true if team.members.count == 1
team.members.count > (team.owners + team.maintainers).count
end
Edited by Ryan Hammond