Skip to content

[FF] remove_trust_scores -- Replaced by delay_user_account_self_deletion

Summary

This issue is to roll out the feature on production, that is currently behind the remove_trust_scores feature flag.

Owners

  • Most appropriate Slack channel to reach out to: #g_sscs_authorization
  • Best individual to reach out to: @mokhax

Expectations

What are we expecting to happen?

Any code path that used the abuse trust scores will be disabled or replaced with an alternate implementation.

What can go wrong and how would we detect it?

Error rates could increase. Abuse scores may not be calculated as previously designed.

Rollout Steps

Rollout on non-production environments

  • Verify the MR with the feature flag is merged to master and has been deployed to non-production environments with /chatops run auto_deploy status https://gitlab.com/gitlab-org/gitlab/-/merge_requests/207883
  • Deploy the feature flag at a percentage (recommended percentage: 50%) with /chatops run feature set remove_trust_scores <rollout-percentage> --actors --dev --pre --staging --staging-ref
  • Monitor that the error rates did not increase (repeat with a different percentage as necessary).
  • Enable the feature globally on non-production environments with /chatops run feature set remove_trust_scores true --dev --pre --staging --staging-ref
  • Verify that the feature works as expected. The best environment to validate the feature in is staging-canary as this is the first environment deployed to. Make sure you are configured to use canary.
  • If the feature flag causes end-to-end tests to fail, disable the feature flag on staging to avoid blocking deployments.
    • See #e2e-run-staging Slack channel and look for the following messages:
      • test kicked off: Feature flag remove_trust_scores has been set to true on **gstg**
      • test result: This pipeline was triggered due to toggling of remove_trust_scores feature flag

If you encounter end-to-end test failures and are unable to diagnose them, you may reach out to the #s_developer_experience Slack channel for assistance. Note that end-to-end test failures on staging-ref don't block deployments.

Before production rollout

  • If the change is significant and you wanted to announce in #whats-happening-at-gitlab, it best to do it before rollout to gitlab-org/gitlab-com.

Specific rollout on production

For visibility, all /chatops commands that target production must be executed in the #production Slack channel and cross-posted (with the command results) to the responsible team's Slack channel.

  • Ensure that the feature MRs have been deployed to both production and canary with /chatops run auto_deploy status <merge-commit-of-your-feature>
  • Depending on the type of actor you are using, pick one of these options:
    • For user-actor: /chatops run feature set --user=mokhax remove_trust_scores true
    • For all internal users: /chatops run feature set --feature-group=gitlab_team_members remove_trust_scores true
  • Verify that the feature works for the specific actors.

Preparation before global rollout

  • Set a milestone to this rollout issue to signal for enabling and removing the feature flag when it is stable.
  • Check if the feature flag change needs to be accompanied with a change management issue. Cross link the issue here if it does.
  • Ensure that you or a representative in development can be available for at least 2 hours after feature flag updates in production. If a different developer will be covering, or an exception is needed, please inform the oncall SRE by using the @sre-oncall Slack alias.
  • Ensure that documentation exists for the feature, and the version history text has been updated.
  • Ensure that any breaking changes have been announced following the release post process to ensure GitLab customers are aware.
  • Notify the #support_gitlab-com Slack channel and your team channel (more guidance when this is necessary in the dev docs).

Global rollout on production

For visibility, all /chatops commands that target production must be executed in the #production Slack channel and cross-posted (with the command results) to the responsible team's Slack channel.

(Optional) Release the feature with the feature flag

WARNING: This approach has the downside that it makes it difficult for us to clean up the flag. For example, on-premise users could disable the feature on their GitLab instance. But when you remove the flag at some point, they suddenly see the feature as enabled and they can't roll it back to the previous behavior. To avoid this potential breaking change, use this approach only for urgent matters.

See instructions if you're sure about enabling the feature globally through the feature flag definition

If you're still unsure whether the feature is deemed stable but want to release it in the current milestone, you can change the default state of the feature flag to be enabled. To do so, follow these steps:

  • Create a merge request with the following changes.
    • If feature was enabled for various actors, ensure the feature has been enabled globally on production /chatops run feature get remove_trust_scores. If the feature has not been globally enabled then enable the feature globally using: /chatops run feature set remove_trust_scores true
    • Set the default_enabled attribute in the feature flag definition to true.
    • Decide which changelog entry is needed.
  • Ensure that the default-enabling MR has been included in the release package. If the merge request was deployed before the monthly release was tagged, the feature can be officially announced in a release blog post: /chatops run release check <merge-request-url> <milestone>
  • After the default-enabling MR has been deployed, clean up the feature flag from all environments by running these chatops command in the #production channel: /chatops run feature delete remove_trust_scores --dev --pre --staging --staging-ref --production
  • Close the feature issue to indicate the feature will be released in the current milestone.
  • Set the next milestone to this rollout issue for scheduling the flag removal.
  • (Optional) You can create a separate issue for scheduling the steps below to Release the feature.
    • Set the title to "[FF] remove_trust_scores - Cleanup".
    • Execute the /copy_metadata <this-rollout-issue-link> quick action to copy the labels from this rollout issue.
    • Link this rollout issue as a related issue.
    • Close this rollout issue.

Release the feature

After the feature has been deemed stable, the clean up should be done as soon as possible to permanently enable the feature and reduce complexity in the codebase.

You can either create a follow-up issue for Feature Flag Cleanup or use the checklist below in this same issue.

  • Create a merge request to remove the remove_trust_scores feature flag. Ask for review/approval/merge as usual. The MR should include the following changes:
    • Remove all references to the feature flag from the codebase.
    • Remove the YAML definitions for the feature from the repository.
  • Ensure that the cleanup MR has been included in the release package. If the merge request was deployed before the monthly release was tagged, the feature can be officially announced in a release blog post: /chatops run release check <merge-request-url> <milestone>
  • Close the feature issue to indicate the feature will be released in the current milestone.
  • Once the cleanup MR has been deployed to production, clean up the feature flag from all environments by running these chatops command in #production channel: /chatops run feature delete remove_trust_scores --dev --pre --staging --staging-ref --production
  • Close this rollout issue.

Rollback Steps

  • This feature can be disabled on production by running the following Chatops command:
/chatops run feature set remove_trust_scores false
  • Disable the feature flag on non-production environments:
/chatops run feature set remove_trust_scores false --dev --pre --staging --staging-ref
  • Delete feature flag from all environments:
/chatops run feature delete remove_trust_scores --dev --pre --staging --staging-ref --production
Edited by 🤖 GitLab Bot 🤖