Skip to content

"Toggle commit list" is not a11y clickable

grafik.png

In the MR overview page is just a <div> with an onclick handler

grafik.png

making it not picked up by screen readers, vimium and other accessibility tools. Please add role=button, a tabindex, space/enter handler, focus state, and selection state. Or just use a <button> for interactive elements, or a <details> Element.

Please also consider adding a11y-related checks (eslint/a11y, or static analysis tools etc) in your deploy process so these kinds of a11y errors are prevented from happening in the first place.

Edited by 🤖 GitLab Bot 🤖