Orphaned ci_job_token_project_scope_links not cleaned up when projects are deleted
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Summary
When projects are deleted, the corresponding ci_job_token_project_scope_links entries are not always cleaned up. This leaves rows pointing to non-existent target_project_ids.
Steps to reproduce
- Create a project A.
- Create a project B.
- Add B to A’s CI job token scope allowlist.
- Delete project B.
- Query ci_job_token_project_scope_links for project A:
select distinct target_project_id from ci_job_token_project_scope_links where target_project_id not in (select distinct id from projects);
Example Project
What is the current bug behavior?
- Orphaned allowlist entries accumulate over time.
- Leads to UI breakage.
What is the expected correct behavior?
- The allowlist entry for the deleted project is removed by background cleanup (via LooseForeignKeys::CleanupWorker).
- No orphaned rows remain.
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)(we will only investigate if the tests are passing)
Possible fixes
Patch release information for backports
If the bug fix needs to be backported in a patch release to a version under the maintenance policy, please follow the steps on the patch release runbook for GitLab engineers.
Refer to the internal "Release Information" dashboard for information about the next patch release, including the targeted versions, expected release date, and current status.
High-severity bug remediation
To remediate high-severity issues requiring an internal release for single-tenant SaaS instances, refer to the internal release process for engineers.