Skip to content

Implement mergeability check for code owner file changes

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Problem to Solve

CODEOWNERS files have a complicated syntax coupled with unique permission requirements that can make it hard to know if the file is configured correctly for users. While provide feedback in the UI:

image

It would be much more appropriate to provide this feedback in the merge request when changes are being proposed.

Proposal

We should introduce a new merge check that helps to validate the CODEOWNERS file in a merge request.

Merge Check Linked Blob View
image image

Additional Details

The merge check should:

  1. Only run when the CODEOWNERS file (in a valid path) is changed in a given merge request. It SHOULD NOT always run on a project.
  2. Should block the merge request from proceeding as a failed merge check

Initially we do not need additional configuration (option to bypass, or allow whether or not failures should block), but we should evaluate feedback to see if these should be added.

Inspiration

Add MR mergeability check for locked paths (!160929 - merged)

Edited by 🤖 GitLab Bot 🤖