Changes integrations settings do not apply - only after deactivation and activation

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Summary

Integration settings are not applied correctly when clicking "Save" button. Settings only take effect after deactivating and reactivating the integration.

Steps to reproduce

  1. Navigate to Project Settings > Integrations
  2. Select an existing integration
  3. Modify any integration settings/configuration
  4. Click the "Save" button
  5. Verify that the new settings are not applied/active
  6. Deactivate the integration
  7. Reactivate the integration
  8. Observe that the settings are now correctly applied

Example Project

What is the current bug behavior?

When modifying integration settings and clicking "Save", the changes are not applied to the active integration. The integration continues to use the previous settings despite the UI showing the save was successful.

What is the expected correct behavior?

When clicking "Save" after modifying integration settings, the new settings should be immediately applied and active for the integration without requiring deactivation/reactivation.

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)
(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:check SANITIZE=true`)
(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`)
(we will only investigate if the tests are passing)

Possible fixes

Patch release information for backports

If the bug fix needs to be backported in a patch release to a version under the maintenance policy, please follow the steps on the patch release runbook for GitLab engineers. Refer to the internal "Release Information" dashboard for information about the next patch release, including the targeted versions, expected release date, and current status.

High-severity bug remediation

To remediate high-severity issues requiring an internal release for single-tenant SaaS instances, refer to the internal release process for engineers.

Edited by 🤖 GitLab Bot 🤖