Skip to content

Rename elasticsearch_* settings in UI to Advanced search

Background

When advanced search was first introduced, the feature only supported integration with Elasticsearch. As a result, much of the initial code (think class names, etc) and UI (including settings names) are named with some flavor of elastic or elasticsearch in names and titles. Advanced search now supports OpenSearch as well as Elasticsearch.

Proposal

Since the feature supports integration with Elasticsearch OR OpenSearch, any user facing messaging (including Admin UI, rake tasks and documentation) should not specify Elasticsearch in the name of things or messaging. All references to Elasticsearch in the admin UI and rake tasks should be converted to reference the feature name instead.

The following discussion from !204258 (merged) should be addressed:

  • @terrichu started a discussion:

    Honestly, I'd like to change all of these settings to visually say this:

    • Elasticsearch indexing --> Advanced search indexing
    • Pause Elasticsearch indexing --> Pause advanced search indexing
    • Search with Elasticsearch enabled --> Search with advanced search enabled

    Is that something I could do in this MR? I hesitate to make a change like this without more communication from us. I don' think it's breaking to change the UI and I'm not recommending to change the backend name of the settings. Though it's unfortunate that the names include elasticsearch. WDYT?

Edited by 🤖 GitLab Bot 🤖